Skip to content

chore: use tinyexec - #1213

Merged
AdrianGonz97 merged 11 commits into
sveltejs:version-1from
sacrosanctic:tinyexec
Aug 28, 2026
Merged

chore: use tinyexec#1213
AdrianGonz97 merged 11 commits into
sveltejs:version-1from
sacrosanctic:tinyexec

Conversation

@sacrosanctic

Copy link
Copy Markdown
Contributor

Closes #

Description

Checklist

  • Update snapshots (if applicable)
  • Add a changeset (if applicable)
  • Allow maintainers to edit this PR
  • I care about what I'm doing, no matter the tool I use (Notepad, Sublime, VSCode, AI...)

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 1, 2026

Copy link
Copy Markdown

Install the latest version of sv from 75416e3:

pnx https://pkg.svelte.dev/sv/c/75416e3dd697cf83282a80ca30e4bdc915ffb027 create

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/cli/pr/1213

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 75416e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sacrosanctic sacrosanctic left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if these are supposed to throw.

Comment thread packages/sv/src/testing.ts Outdated
Comment thread packages/sv/src/testing.ts Outdated
Comment thread packages/sv/src/addons/tests/vitest/test.ts
Comment thread packages/sv/src/core/verifiers.ts Outdated
Comment thread packages/sv/src/core/verifiers.ts Outdated
Comment thread packages/sv/src/core/formatFiles.ts Outdated
Comment thread packages/sv/src/addons/tests/drizzle/test.ts Outdated
Comment thread packages/sv/src/testing.ts Outdated
Comment thread packages/sv/src/addons/tests/drizzle/test.ts Outdated
Comment thread packages/sv/src/addons/tests/better-auth/test.ts Outdated
Comment thread packages/sv/src/addons/tests/better-auth/test.ts Outdated
Comment thread packages/sv/src/addons/tests/drizzle/test.ts Outdated
Comment thread packages/sv/src/create/tests/check.ts
@sacrosanctic

Copy link
Copy Markdown
Contributor Author

I just learned that execsync still throws even when it is false if the command itself is invalid...

@manuel3108
manuel3108 changed the base branch from main to version-1 August 7, 2026 08:52
@manuel3108

Copy link
Copy Markdown
Member

Whats the state of the open comments? Should / will they be handled here or should we proceed with this for the time being?

@sacrosanctic

Copy link
Copy Markdown
Contributor Author

The 2 open comments are resolved. I added some comments for context.

@manuel3108 manuel3108 added the needs-addon-integration-tests Run the addon integration test suite label Aug 28, 2026
@AdrianGonz97
AdrianGonz97 merged commit 0972d25 into sveltejs:version-1 Aug 28, 2026
8 of 9 checks passed
@sacrosanctic
sacrosanctic deleted the tinyexec branch August 28, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-addon-integration-tests Run the addon integration test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants