fix: relax community add-on requirements (alternate) - #1233
Open
AdrianGonz97 wants to merge 4 commits into
Open
Conversation
|
Install the latest version of pnx https://pkg.svelte.dev/sv/c/3d0be1f27f57e11b6c3af0c3248a98059a8c1c2d createOpen in |
🦋 Changeset detectedLatest commit: 3d0be1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* fix(addon): harden add-on entry point resolution Try `./sv` then `.` as documented, instead of bailing on the first failure. Stop rejecting valid `exports` shapes (bare string, conditions only, absent) before attempting an import, handle the CJS `MODULE_NOT_FOUND` code, and keep Node's message so the missing module is named. Document that `sv` provides `@sveltejs/sv-utils` and that leaving it unbundled couples the add-on to whatever version `sv` ships. * Update packages/sv/src/core/common.ts Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com> --------- Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>
jycouet
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative to #1224
Closes #1210
Rather than simply checking the export conditions and dependency fields for non-bundled deps, we'll instead try to load the module and handle the specific node error code for missing modules, which would be indicative of deps that are not bundled.
note: this hasn't been tested on Bun or Deno yet. their missing module error codes could be different. will do that shortly.It looks to work on Bun and Deno as well (though if someone else could verify this as well, that would be great!)Checklist