Skip to content

fix: forward exit code of external package commands - #412

Merged
benmccann merged 5 commits into
sveltejs:mainfrom
rChaoz:fix/check-exit-code
Jan 22, 2025
Merged

fix: forward exit code of external package commands#412
benmccann merged 5 commits into
sveltejs:mainfrom
rChaoz:fix/check-exit-code

Conversation

@rChaoz

@rChaoz rChaoz commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

Closes #411

@changeset-bot

changeset-bot Bot commented Jan 22, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f244c74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Jan 22, 2025

Copy link
Copy Markdown

Open in Stackblitz

npm i https://pkg.pr.new/sveltejs/cli/sv@412
npm i https://pkg.pr.new/sveltejs/cli/svelte-migrate@412

commit: f244c74

Comment thread packages/cli/commands/check.ts Outdated
@benmccann

Copy link
Copy Markdown
Member

We should check all the commands and add it anywhere it is missing such as

rChaoz and others added 2 commits January 22, 2025 02:47
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@rChaoz

rChaoz commented Jan 22, 2025

Copy link
Copy Markdown
Contributor Author

@benmccann should be all good

@rChaoz rChaoz changed the title fix: forward exit code of svelte-check fix: forward exit code of external package commands Jan 22, 2025
Comment thread .changeset/proud-apples-watch.md Outdated
@benmccann
benmccann merged commit ea45ddb into sveltejs:main Jan 22, 2025
@benmccann

Copy link
Copy Markdown
Member

Thank you!!

@github-actions github-actions Bot mentioned this pull request Jan 22, 2025
@rChaoz
rChaoz deleted the fix/check-exit-code branch January 22, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sv check always returns exit code 0

2 participants