chore: update project structure - #838
Conversation
|
commit: |
manuel3108
left a comment
There was a problem hiding this comment.
According to the diff, a few tests got deleted. Any reason why?
Ohhhh, they are re-added in another place. Probably just git fucking around with so many files.
Deleted the change set, as this is not "customer facing" and only internal, similar to the other PRs we merged.
Cool that you managed to keep the testing setup for pnpm test --project core and so on. In the future we could thing about extracting all of the long running "create" and "addon" tests into a seperate package or something, so that you could just run "pnpm test" in the sv directory again. But we can bother about that at a later point.
Also some of these imports became really long, we could consider a path alias or something.
But apart from that, I did not see anything that is not working, so merging this to get it out of the way.
Thanks 🥳
It has changed about 2 months ago, oops: sveltejs/cli#838
git mv ...to preserve git history (please pull and check!)Gist of the PR
packages/cli->packages/svpackages/core->packages/sv/lib/corepackages/create->packages/sv/lib/createpackages/addons->packages/sv/lib/addonspackages/cli/commands->packages/sv/lib/cliPreparing work for
community;)