Skip to content

feat(eslint): remove vscode eslint.validate - #871

Merged
jycouet merged 6 commits into
sveltejs:mainfrom
KiRura:fix/create-eslint.validate
Jan 18, 2026
Merged

feat(eslint): remove vscode eslint.validate#871
jycouet merged 6 commits into
sveltejs:mainfrom
KiRura:fix/create-eslint.validate

Conversation

@KiRura

@KiRura KiRura commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

https://svelte.jp/docs/cli/eslint states:

What you get
updated .vscode/settings.json

However, when settings.json already exists and eslint.validate is undefined, the settings are not updated, preventing the ESLint extension from linting .svelte files.

@changeset-bot

changeset-bot Bot commented Jan 8, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 584408b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jycouet jycouet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this.
Could you add a changelog? (pnpm changeset and looking at others in CHANGELOG.md, find something that fit :) )

Comment thread packages/sv/lib/addons/eslint/index.ts Outdated
Comment thread packages/sv/lib/addons/eslint/index.ts Outdated
@jycouet

jycouet commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Actually, according to #846 we don't need this eslint.validate anymore!

@pkg-pr-new

pkg-pr-new Bot commented Jan 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@871
npx https://pkg.pr.new/sveltejs/cli/sv@871

commit: 584408b

@jycouet

jycouet commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Sorry, I jeopardize your PR @KiRura ! Do you still agree?

Like this it would:

@hyunbinseo could you have a look as well ?
@manuel3108 could you check as well api / naming ?

Thx :)

@KiRura

KiRura commented Jan 9, 2026

Copy link
Copy Markdown
Contributor Author

Yes, that's fine with me!
I wasn't aware that files.associations could work instead of eslint.validate. I apologize for my lack of knowledge.

@KiRura KiRura changed the title fix: ensure eslint.validate is created when missing feat(eslint): with dbaeumer.vscode-eslint@3.0.20 ESLint extension, we don't need to set eslint.validate anymore Jan 9, 2026
@jycouet jycouet changed the title feat(eslint): with dbaeumer.vscode-eslint@3.0.20 ESLint extension, we don't need to set eslint.validate anymore feat(eslint): remove vscode eslint.validate Jan 11, 2026
@jycouet
jycouet merged commit a555c73 into sveltejs:main Jan 18, 2026
8 checks passed
@github-actions github-actions Bot mentioned this pull request Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants