breaking: require Node 18.13 or newer

[benmccann]

Should we remove the shouldPolyfill method and polyfill whenever it's not already on globalThis?

Closes #10527

[changeset-bot]

🦋 Changeset detected

Latest commit: dff154f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@sveltejs/adapter-node	Major
@sveltejs/kit	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dummdidumm]

Which shouldPolyfill are you talking about?

[benmccann]

Looks like I forgot about our naming convention and it's called should_polyfill 😆

kit/packages/kit/src/exports/vite/dev/index.js

Line 29 in 3d98c37

if (should_polyfill) {

[dummdidumm]

I see - how are the two related? Is this a "while we're at it.."-thing? Do Bun/Deno (the ones we check in that const) not have these? Or is this for a more general future-proof thing?

[benmccann]

I just went through our history to see how this all came about. It looks like we tried to detect whether the APIs were available, but it didn't work because undici had the APIs available, but with some missing functionality. Now we don't have that constraint anymore, so can remove a bunch of code to simplify things like removing the polyfill option from adapter-node. I also think at one point we didn't trust the undici bundled with Node and so preferred to force polyfill the APIs, but that also won't be applicable anymore.

[dummdidumm]

Ok so you're proposing to remove should_polyfill and instead do if (!(x in globalThis)) { globalThis.x = x } in the polyfill method?

[benmccann]

Yeah. I pushed that change