Skip to content

feat: fine grained search param invalidation - #11258

Merged
Rich-Harris merged 40 commits into
version-2from
fine-grained-search-params
Dec 11, 2023
Merged

feat: fine grained search param invalidation#11258
Rich-Harris merged 40 commits into
version-2from
fine-grained-search-params

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

#11066 with a few changes (I couldn't commit directly to the PR)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

paoloricciuti and others added 30 commits November 17, 2023 13:16
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Dec 11, 2023

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2121520

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Rich-Harris merged commit 6421015 into version-2 Dec 11, 2023
@Rich-Harris
Rich-Harris deleted the fine-grained-search-params branch December 11, 2023 04:19
@github-actions github-actions Bot mentioned this pull request Dec 14, 2023
Rich-Harris pushed a commit that referenced this pull request Aug 19, 2026
…ch parameter changes (#16495)

Since #11258, `diff_search_params` compares each key's values as a set,
so navigating from `?x=a&x=a` to `?x=a` is treated as unchanged and load
functions tracking `x` don't rerun. Comparing the sorted value lists
instead catches count changes, still treats reordering as unchanged, and
is O(V log V) rather than O(V²).

### Please don't delete this checklist! Before submitting the PR, please
make sure you do the following:

- [ ] It's really useful if your PR references an issue where it is
discussed ahead of time. In many cases, features are absent for a
reason. For large changes, please create an RFC:
https://github.com/sveltejs/rfcs
- [x] This message body should clearly illustrate what problems it
solves.
- [x] Ideally, include a test that fails without this PR but passes with
it.

### Tests

- [x] Run the tests with `pnpm test` and lint the project with `pnpm
lint` and `pnpm check`

### Changesets

- [x] If your PR makes a change that should be noted in one or more
packages' changelogs, generate a changeset by running `pnpm changeset`
and following the prompts. All changesets should be `patch` until
SvelteKit 2.0 (major releases only that fix regressions)

### Edits

- [ ] Please ensure that 'Allow edits from maintainers' is checked. PRs
without this option may be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants