Skip to content

chore: better cookie migration - #11273

Closed
dummdidumm wants to merge 2 commits into
version-2from
cookie-migration-2
Closed

chore: better cookie migration#11273
dummdidumm wants to merge 2 commits into
version-2from
cookie-migration-2

Conversation

@dummdidumm

Copy link
Copy Markdown
Member

'.' is equivalent to the current default behavior, therefore use that instead of just adding a comment

'.' is equivalent to the current default behavior, therefore use that instead of just adding a comment
@changeset-bot

changeset-bot Bot commented Dec 12, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0882cb5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris

Copy link
Copy Markdown
Member

It's not equivalent. The default turns /foo/bar into /foo; . turns /foo/bar into /foo/

@dummdidumm

Copy link
Copy Markdown
Member Author

That's not what I'm seeing in my tests. I added a console.log into set_internal in cookie.js and it turns /foo/bar into /foo and /foo/bar/ into /foo/bar, just as the default browser behavior

@Rich-Harris Rich-Harris mentioned this pull request Dec 12, 2023
5 tasks
@Rich-Harris

Copy link
Copy Markdown
Member

Turns out our path resolution was faulty. Fixed in #11276. Once that's merged, my statement above...

The default turns /foo/bar into /foo; . turns /foo/bar into /foo/

...will become true, meaning we should close this PR.

@benmccann
benmccann deleted the cookie-migration-2 branch February 13, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants