fix: prevent endless SPA 404 loop - #11354
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 9936f5a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
Perhaps we could add a test that would fail without this change? I think we've got a couple test apps that use a fallback page |
Member
Author
|
I ended up creating a new test app because many of the other ones rely on ssr being enabled. This test specifically requires SSR to be disabled in the root layout so that the error page isn't server-side rendered. |
benmccann
approved these changes
Dec 18, 2023
Member
|
thank you! |
Merged
caleb531
added a commit
to caleb531/personal-website
that referenced
this pull request
Dec 18, 2023
Including several fixes for a serious 404 bug in SvelteKit. See: <sveltejs/kit#11354>
6 tasks
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 22, 2026
…error page (#16381) After an error page renders, `current.route` is `null` (`load_root_error_page` stores `route: null` in the navigation state). The next navigation computes ```js const route_changed = current.route ? route.id !== current.route.id : false; ``` so the route counts as unchanged no matter where the user goes next. A root layout server load that tracked `route` is then skipped as fresh, and its data from before the error page renders on the new page. The new test's failing assertion on `version-3` shows the layout still claiming the previous route: ``` Expected: "/b" Received: "/a" ``` A missing `current.route` now counts as changed. On a first-ever navigation the flag is irrelevant, the node has no previous data to reuse anyway, so the only behavior change is the conservative refetch after error pages. The interaction was never designed. `route: null` came in #6552 to give `beforeNavigate` a value meaning "no matched route", and the guard came two months later in #7450 with route tracking itself, mirroring the adjacent `url_changed` null-guard. Neither discussed the error-page case. The test lives in the no-ssr app. Its root layout gains a server load returning `route.id`, the navigation's data request is intercepted with a 500 to produce the error page, and the follow-up navigation must show the new route id. The app's root `+layout.server.js` was an empty file, shipped by #11354 so its 404-loop test has a server load node in dev; giving it a real load keeps that trigger intact. Found while reviewing #16380, which mirrors this computation for the error page itself and carries the same one-line fix. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11227
This PR reverts the changes in #11025 that reloaded the page when fetching data failed. Now, it just avoids parsing the response body if it's not JSON and returns the same HttpError with a simplified error message based on the status (we have been doing the same in the server).
No test unless we want to setup a new test suite without a root error load function to reproduce the issue.quick reproduction: https://github.com/eltigerchino/sveltekit-bug-11227
pnpm i && pnpm dev/examplePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.