Skip to content

fix: remove images from route-level config - #12280

Merged
Rich-Harris merged 6 commits into
mainfrom
vercel-types
Jun 5, 2024
Merged

fix: remove images from route-level config#12280
Rich-Harris merged 6 commits into
mainfrom
vercel-types

Conversation

@benmccann

Copy link
Copy Markdown
Member

The include in the tsconfig.json was causing the index file in adapter-vercel not to be type checked. I removed it to type check all files. I added images to the edge config to get it to pass. @dummdidumm could you verify if that's correct?

@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label May 30, 2024
@benmccann
benmccann requested a review from dummdidumm May 30, 2024 21:01
@changeset-bot

changeset-bot Bot commented May 30, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ad7bc00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread packages/adapter-vercel/index.d.ts
@benmccann benmccann changed the title fix: add images to edge config types fix: remove images from route-level config Jun 5, 2024
@benmccann

Copy link
Copy Markdown
Member Author

Awesome. Thanks for the help in getting this over the finish line!

@Conduitry

Copy link
Copy Markdown
Member

stupid-lies-remain as a changeset filename feels like an omen on a PR where we are bending the rules of semver.

They remain.

@Rich-Harris
Rich-Harris merged commit 7133648 into main Jun 5, 2024
@Rich-Harris
Rich-Harris deleted the vercel-types branch June 5, 2024 19:39
@github-actions github-actions Bot mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:adapter-vercel Pertaining to the Vercel adapter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants