fix: service worker base path in dev mode - #12577
Merged
dummdidumm merged 5 commits intoJan 15, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 28294e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Oct 9, 2024
Member
|
Thanks for the PR! Is this test suite a good fit for your test? I noticed it also has a test with a base path and a service worker. |
Contributor
Author
Hey, thank you for the review. Saw it a bit late :-) will go through it 👍🏻 |
Contributor
Author
The tests are skipped in dev mode 👍🏻 let me just add relevant test cases there 💪🏻 |
Contributor
Author
|
@eltigerchino added the tests and your comment 👍🏻 |
teemingc
approved these changes
Oct 17, 2024
Member
|
Thank you! I'll wait for another review before merging just to sanity check this. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a service worker in dev mode was not respecting the configured base path and it was missing from the filesystem import.
This PR prepends the base path before the filesystem import.
In a case with the basepath of
/console,http://localhost:3000/console/service-worker.jswill resolve now to:I didn't find a good place to add a test though. I could add another
packages/kit/test/apps/dev-onlytest suite with a base path, but I'd rather wait on some feedback if this is the right choice 👍🏻Created a PoC of what the tests could look like => TorstenDittmann/kit@fix-service-worker-base-path...fix-service-worker-base-path-tests
More context to this issue can be found here => #12039
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits