fix: use resolve_symlinks for node.universal and node.server - #12740
Merged
Conversation
🦋 Changeset detectedLatest commit: 25df6eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
reviewed
Oct 6, 2024
Member
|
Thanks! The repro works well and I've tested the fix with it. Can you add a test for this? Maybe in one of the other test suite folders we could try to make it so the build fails? Otherwise, it looks good to me. |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
dummdidumm
approved these changes
Jan 16, 2025
dummdidumm
left a comment
Member
There was a problem hiding this comment.
symlink tests are close to impossible to write in a good way (for example there's one I believe which always fails on windows for me), so I'm ok with this not having a test
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seems to fix following issue with symbolic links in the routes #8100
Minimal issue reproduction is available here: https://github.com/yukipastelcat/sveltekit-symlinks
Symbolic links in the reproduction repository will be created automatically during build, but my plugin is flaky, so you might need to run
npm run buildfor the second time to reproduce the issue.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkpnpm testcommand does not exist, so I ranpnpm test:kitinstead, some tests are failing, but they also do it in themainbranch.Changesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits