Skip to content

feat(vite): support custom configFile path for sveltekit plugin - #13749

Closed
axel7083 wants to merge 2 commits into
sveltejs:mainfrom
axel7083:feature/vite/sveltekit-plugin-config-file-support
Closed

feat(vite): support custom configFile path for sveltekit plugin#13749
axel7083 wants to merge 2 commits into
sveltejs:mainfrom
axel7083:feature/vite/sveltekit-plugin-config-file-support

Conversation

@axel7083

@axel7083 axel7083 commented Apr 28, 2025

Copy link
Copy Markdown

Fixes #13748


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Apr 28, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c68754

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann

Copy link
Copy Markdown
Member

The motivation here isn't clear, but this looks like something to support monorepos? That's come up several times in the past (#13027, #12420, #12410) and folks thought it would be best for it to be addressed via the monorepo tooling: #12499 (comment)

@benmccann

Copy link
Copy Markdown
Member

Closing this given the lack of response and feedback from other maintainers on similar PRs in the past

@benmccann benmccann closed this May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

allow passing configFile option to kit() in vite config

2 participants