fix: HMR for query - #14587
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 0f07994 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Oct 2, 2025
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
* accept hot updates * update cached entries * changeset * Update packages/kit/src/runtime/client/remote-functions/query.svelte.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present, if you have something like this...
...nothing immediately changes if you change the return value of
foo— you have to reload the page to see the new data. This is unsatisfying.With this PR, hot updates are accepted by the transformed remote module, and upon creating the replacement query we refresh anything that's currently referenced in an effect. The end result is HMR for queries.
Unfortunately this approach doesn't extend to
prerender, because prerender functions don't use state and thus cannot be reactively updated. We could change that, but we would only want to change it in dev, and it would be a whole thing. Maybe we'll want to do that at some point anyway though.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits