fix: expose issue.path in .allIssues() for field containers - #14784
Merged
Conversation
🦋 Changeset detectedLatest commit: 0ab1434 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sillvva
marked this pull request as draft
October 23, 2025 04:33
sillvva
marked this pull request as ready for review
October 23, 2025 05:17
Merged
1 task
Member
|
I don't love that we added a new interface for this. Wouldn't it be simpler to just add |
Member
|
opened #14864 |
Contributor
Author
|
You're right. I could have done that too. |
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…tejs#14784) fixes sveltejs#14688 Changes .allIssues() from { message: string } to the following to indicate where in the field container the issue occurred.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14688
Changes
.allIssues()from{ message: string }to the following to indicate where in the field container the issue occurred.Demo
As the issue shows, this can be used to group issues with
Object.groupBy().Discriminated Unions
#14771 was a big step forward to being able to work with discriminated union schemas. However, you still can't get the issues for a field in a D.U. Having access to the path here would be the final thing needed to support D.U. schemas. You still can't use
.as()or.issues(), but you can set the attributes manually like this:Discriminated Union Demo
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits