fix: prefix route pathname with hash when using resolve with hash routing enabled - #14786
Merged
Conversation
added 2 commits
October 22, 2025 17:17
🦋 Changeset detectedLatest commit: 4318d08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
added 2 commits
October 22, 2025 17:24
Merged
1 task
gwennlbh
added a commit
to cigaleapp/cigale
that referenced
this pull request
Nov 3, 2025
might wanna just use sveltekit resolve() directly in the future see github.com/sveltejs/kit/pull/14786/
renovate Bot
added a commit
to cigaleapp/cigale
that referenced
this pull request
Nov 3, 2025
* ⬆️ Update dependency @sveltejs/kit to ^2.48.4 * update $lib/paths:href to just use resolve() might wanna just use sveltekit resolve() directly in the future see github.com/sveltejs/kit/pull/14786/ * fix root redirect --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Gwenn Le Bihan <gwenn.lebihan7@gmail.com>
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
…outing enabled (sveltejs#14786) fixes sveltejs#14785 This PR changes the client-side resolve implementation to take into account the hash router setting. As a result, it'll add a hash so you get a route such as /base#/my-route which is what you want when hash routing is enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14785
This PR changes the client-side
resolveimplementation to take into account the hash router setting. As a result, it'll add a hash so you get a route such as/base#/my-routewhich is what you want when hash routing is enabled.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits