fix: copy public directory assets if client build is skipped - #16004
Merged
Conversation
|
teemingc
commented
Jun 10, 2026
| expect(img_response.status()).toBe(200); | ||
|
|
||
| const public_asset_response = await request.get('/asset.json'); | ||
| expect(public_asset_response.status()).toBe(200); |
Member
Author
There was a problem hiding this comment.
The test checks that the public assets are accessible after build
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assets in the public directory
staticare not copied to theoutput/clientdirectory during the server build. This means if the client build is skipped (which is now possible because of #15936), the public assets are never copied over.This PR manually copies these assets over because setting the Vite option
copyPublicDir: truesimply copies them to theoutput/serverdirectory.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.No changeset because #15936 hasn't been released yet.
Edits