Skip to content

breaking: disallow omitted Content-Type header - #16347

Merged
teemingc merged 5 commits into
version-3from
disallow-no-content-type
Jul 14, 2026
Merged

breaking: disallow omitted Content-Type header#16347
teemingc merged 5 commits into
version-3from
disallow-no-content-type

Conversation

@teemingc

@teemingc teemingc commented Jul 14, 2026

Copy link
Copy Markdown
Member

closes #15389

This PR changes the CSRF check to disallow requests omitting a content-type header.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 14, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from f8665c2:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/f8665c2b9eed2f2c683792cacd971e4f04c6d58c

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16347

@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f8665c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc changed the title fix: disallow omitted Content-Type header breaking: disallow omitted Content-Type header Jul 14, 2026
@teemingc teemingc linked an issue Jul 14, 2026 that may be closed by this pull request
@svelte-docs-bot

Copy link
Copy Markdown

@teemingc

Copy link
Copy Markdown
Member Author

We've got a bunch of unit tests sending POST requests without any content-type header. Looking at them now

@teemingc
teemingc merged commit b148d31 into version-3 Jul 14, 2026
18 checks passed
@teemingc
teemingc deleted the disallow-no-content-type branch July 14, 2026 16:16
@teemingc teemingc mentioned this pull request Jul 14, 2026
Rich-Harris pushed a commit that referenced this pull request Jul 17, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/kit@3.0.0-next.9

### Major Changes

- breaking: `handle`'s `resolve` is now typed to always return a
`Promise` ([#16352](#16352))

- breaking: replace the `$lib` alias with `#lib` and remove `files.lib`
config. ([#16360](#16360))

- breaking: disallow cross-origin form submissions without a
`Content-Type` header
([#16347](#16347))

- breaking: Server-only directories (`/server/` in the path) are now
treated as server-only everywhere inside the project (except
`src/routes` and the assets directory)
([#16360](#16360))

- breaking: delegate CORS handling to Vite for static directory requests
during development
([#16357](#16357))

### Minor Changes

- feat: reinstate `$env/static/private`, `$env/dynamic/private`,
`$env/static/public`, `$env/dynamic/public` and `$app/environment` as
deprecated aliases for `$app/env/private` `$app/env/public` and
`$app/env` ([#16334](#16334))

### Patch Changes

- perf: cache the default cookie header parse and avoid allocations in
`cookies.get` ([#16341](#16341))

- fix: avoid client-side code being bundled by Cloudflare Wrangler
([#16364](#16364))

- fix: handle rejected streamed server data after delayed loads
([#16268](#16268))

- fix: enable CSRF protection in builds with a non-production `NODE_ENV`
value ([#16313](#16313))
## @sveltejs/package@3.0.0-next.3

### Minor Changes

- feat: transform import aliases into relative imports in files
([#16360](#16360))
## @sveltejs/adapter-node@6.0.0-next.4

### Patch Changes

- fix: correctly bundle entrypoints on Windows
([#16367](#16367))
- Updated dependencies
[[`c1ee782`](c1ee782),
[`1a1b3ea`](1a1b3ea),
[`6423d98`](6423d98),
[`6d1f4f0`](6d1f4f0),
[`5ca9906`](5ca9906),
[`b148d31`](b148d31),
[`5ca9906`](5ca9906),
[`9f3d9bb`](9f3d9bb),
[`7bfd922`](7bfd922),
[`ffa0e3b`](ffa0e3b)]:
  - @sveltejs/kit@3.0.0-next.9
## @sveltejs/enhanced-img@1.0.0-next.2

### Patch Changes

- chore: replace the `$lib` alias with `#lib` in docs
([#16360](#16360))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stricter CSRF checks

2 participants