feat: make `$app/paths` importable in service workers by Rich-Harris · Pull Request #16441 · sveltejs/kit

Rich-Harris · 2026-07-20T18:50:35Z

Part of #16159. This makes $app/paths importable in service workers, which removes the last import from $service-worker that might be necessary.

It's a tiny bit hacky albeit a fairly non-invasive change: match now needs to delegate to a per-environment match_implementation that gets overridden in client.js.

Once this is merged I'll open a PR removing $service-worker altogether.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

pkg-svelte-dev · 2026-07-20T18:50:38Z

Install the latest version of @sveltejs/kit from 9267dc3:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9267dc3b17ab98c06f27606b65bdc99262fb3d6e

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16441

changeset-bot · 2026-07-20T18:50:40Z

🦋 Changeset detected

Latest commit: 9267dc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svelte-docs-bot · 2026-07-20T18:52:46Z

Preview: https://svelte-dev-git-preview-kit-16441-svelte.vercel.app/

@PARAM

…from `$app/types`, causing a `Cannot find name 'RouteParams'` error under `checkJs`. This commit fixes the issue reported at packages/kit/src/runtime/app/paths/internal/client.js:13 ## Bug In `packages/kit/src/runtime/app/paths/internal/client.js`, the top-of-file JSDoc import was: ```js /** @import { RouteId, Path } from '$app/types' */ ``` but the `@returns` annotation on `match_implementation` references `RouteParams<K>`: ```js /** * @PARAM {Path | URL | (string & {})} _url * @returns {Promise<{ [K in RouteId]: { id: K; params: RouteParams<K>; } }[RouteId] | null>} */ ``` `RouteParams` is a type exported from the ambient `declare module '$app/types'` (see `packages/kit/src/types/ambient.d.ts:147`), not a global. With `checkJs: true` in `tsconfig.json`, TypeScript type-checks JSDoc annotations, so referencing the un-imported `RouteParams` produces `Cannot find name 'RouteParams'`, failing `pnpm check` in CI. This regressed when `match` was moved out of `paths/client.js` (whose `@import` list *does* include `RouteParams`) into `internal/client.js`, but only `RouteId` and `Path` were carried over. ## Fix Add `RouteParams` to the `@import` list: ```js /** @import { RouteId, Path, RouteParams } from '$app/types' */ ``` This matches the pattern already used in `paths/client.js`, which imports `RouteParams` alongside the other types. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: Rich-Harris <hello@rich-harris.dev>

…after switching to `resolve('')` the value is now `/basepath/` (with trailing slash), so the `build /basepath/service-worker.js` test fails. This commit fixes the issue reported at packages/kit/test/apps/options-2/src/service-worker.js:8 ## Bug `packages/kit/test/apps/options-2/src/service-worker.js` was changed to compute the base via `$app/paths`: ```js import { resolve } from '$app/paths'; self.base = resolve(''); ``` In `packages/kit/src/runtime/app/paths/client.js`, `resolve` handles a non-slash-prefixed argument via its last branch: ```js return base + pathname_prefix + '/' + args[0]; ``` For `resolve('')`, `''[0]` is `undefined` (not `'/'`), so it returns `base + '' + '/' + '' = /basepath/` — **with a trailing slash**. This matches the behavior asserted elsewhere in the app (`test/test.js` expects `base: /basepath/` when JS is enabled). The previous implementation used `base` from `$service-worker`, whose value is `/basepath` (no trailing slash). The service-worker test was not updated for the new behavior: ```js // packages/kit/test/apps/options-2/test/service-worker.test.js:42 expect(self.base).toBe('/basepath'); ``` ## Trigger Running the `build /basepath/service-worker.js` test (non-DEV) executes the built service worker, sets `self.base = resolve('') === '/basepath/'`, and the assertion `expect(self.base).toBe('/basepath')` fails. ## Fix Updated the test assertion to match the new, correct value produced by `resolve('')`: ```js expect(self.base).toBe('/basepath/'); ``` This is consistent with the rest of the options-2 app, which expects `resolve('')` to yield `/basepath/` with JS enabled. Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: Rich-Harris <hello@rich-harris.dev>

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated. ⚠️

⚠️

⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`. ⚠️

⚠️

⚠️ # Releases ## @sveltejs/kit@3.0.0-next.12 ### Major Changes - breaking: rename `Pathname` type to `Path` and `Asset` to `AssetPath` ([#16430](#16430)) breaking: remove leading `/` from `Path` and `AssetPath` - breaking: write tsconfig to `node_modules/$app/tsconfig` ([#16458](#16458)) - breaking: error on `event.url`, `event.params` and `event.route` access inside queries ([#16452](#16452)) - breaking: delete `$service-worker` module ([#16450](#16450)) - breaking: detect new deployments on data, remote, and form action responses, tab focus, and visibility change, and default `version.pollInterval` to 1 hour ([#16496](#16496)) ### Minor Changes - feat: add `$app/manifest` module with `immutable`, `assets`, `prerendered`, and `routes` exports ([#16372](#16372)) - feat: validate that all remote form fields were created with form.fields.foo.as(...) ([#16331](#16331)) - feat: make `$app/paths` importable in service workers ([#16441](#16441)) - feat: `$app/service-worker` module ([#16458](#16458)) - feat: better tsconfig validation ([#16458](#16458)) - fix: default cookies to `secure` to `false` during development ([#16462](#16462)) ### Patch Changes - fix: allow `undefined` values to be passed to form field `.as(...)` where applicable ([#15681](#15681)) - fix: include queries refreshed from within another query in the serialized response ([#16461](#16461)) - fix: generate sourcemaps for remote modules ([#16440](#16440)) - fix: avoid empty getElementById() call on hash routing navigation ([#16448](#16448)) - fix: warn if hook files are spelled as "hook" instead of "hooks" ([#16483](#16483)) - chore: deprecate the `alias` option ([#16470](#16470)) - fix: prevent infinite loops when server-side queries refresh each other in a cycle during the single-flight drain ([#16461](#16461)) - fix: populate `version` in service workers ([#16434](#16434)) - fix: resolve remote modules as external during dev prebundling so packages can re-export remote functions ([#16426](#16426)) - fix: refetch route-tracking server data when navigating away from an error page ([#16381](#16381)) - fix: serialize `query(...).set(...)`/`query(...).refresh()` values into the rendered HTML when called from within a query during SSR ([#16461](#16461)) - fix: fall back to the page's form actions when a sibling endpoint has no POST handler ([#16349](#16349)) - fix: return a lightweight 404 instead of rendering the error page for subresource requests ([#16463](#16463)) - fix: preserve stripped path prefixes by making trailing-slash redirects relative ([#16431](#16431)) - chore: deduplicate type-stripping logic in `tweak_types` ([#16454](#16454)) - fix: more informative error message when running a command inside a query or prerender function ([`eb5c973`](eb5c973)) ## @sveltejs/adapter-cloudflare@8.0.0-next.3 ### Patch Changes - chore: bump `@cloudflare/workers-types` to `4.20260621.1` ([#16455](#16455)) - Updated dependencies [[`adc4c5b`](adc4c5b), [`ecb0701`](ecb0701), [`4b4cc60`](4b4cc60), [`7390dbe`](7390dbe), [`2e71340`](2e71340), [`c87bc3a`](c87bc3a), [`af15c6c`](af15c6c), [`c6fa431`](c6fa431), [`bfe4dea`](bfe4dea), [`df7dc72`](df7dc72), [`5ae11a1`](5ae11a1), [`781205c`](781205c), [`c87bc3a`](c87bc3a), [`a1bfeb9`](a1bfeb9), [`c87bc3a`](c87bc3a), [`9f0127d`](9f0127d), [`4b4cc60`](4b4cc60), [`8f5b9c7`](8f5b9c7), [`c9b5544`](c9b5544), [`fe1d4a4`](fe1d4a4), [`4b4cc60`](4b4cc60), [`5f78e95`](5f78e95), [`25510fc`](25510fc), [`c99a6cf`](c99a6cf), [`17a45ca`](17a45ca), [`2ca20c3`](2ca20c3), [`eb5c973`](eb5c973)]: - @sveltejs/kit@3.0.0-next.12 ## @sveltejs/adapter-netlify@7.0.0-next.4 ### Patch Changes - fix: await `init` on every request to prevent race condition ([#16467](#16467)) - chore: bump Rolldown to `1.2.0` ([#16455](#16455)) - Updated dependencies [[`adc4c5b`](adc4c5b), [`ecb0701`](ecb0701), [`4b4cc60`](4b4cc60), [`7390dbe`](7390dbe), [`2e71340`](2e71340), [`c87bc3a`](c87bc3a), [`af15c6c`](af15c6c), [`c6fa431`](c6fa431), [`bfe4dea`](bfe4dea), [`df7dc72`](df7dc72), [`5ae11a1`](5ae11a1), [`781205c`](781205c), [`c87bc3a`](c87bc3a), [`a1bfeb9`](a1bfeb9), [`c87bc3a`](c87bc3a), [`9f0127d`](9f0127d), [`4b4cc60`](4b4cc60), [`8f5b9c7`](8f5b9c7), [`c9b5544`](c9b5544), [`fe1d4a4`](fe1d4a4), [`4b4cc60`](4b4cc60), [`5f78e95`](5f78e95), [`25510fc`](25510fc), [`c99a6cf`](c99a6cf), [`17a45ca`](17a45ca), [`2ca20c3`](2ca20c3), [`eb5c973`](eb5c973)]: - @sveltejs/kit@3.0.0-next.12 ## @sveltejs/adapter-node@6.0.0-next.6 ### Patch Changes - fix: preserve stripped path prefixes by making trailing-slash redirects relative ([#16431](#16431)) - chore: bump Rolldown to `1.2.0` ([#16455](#16455)) - Updated dependencies [[`adc4c5b`](adc4c5b), [`ecb0701`](ecb0701), [`4b4cc60`](4b4cc60), [`7390dbe`](7390dbe), [`2e71340`](2e71340), [`c87bc3a`](c87bc3a), [`af15c6c`](af15c6c), [`c6fa431`](c6fa431), [`bfe4dea`](bfe4dea), [`df7dc72`](df7dc72), [`5ae11a1`](5ae11a1), [`781205c`](781205c), [`c87bc3a`](c87bc3a), [`a1bfeb9`](a1bfeb9), [`c87bc3a`](c87bc3a), [`9f0127d`](9f0127d), [`4b4cc60`](4b4cc60), [`8f5b9c7`](8f5b9c7), [`c9b5544`](c9b5544), [`fe1d4a4`](fe1d4a4), [`4b4cc60`](4b4cc60), [`5f78e95`](5f78e95), [`25510fc`](25510fc), [`c99a6cf`](c99a6cf), [`17a45ca`](17a45ca), [`2ca20c3`](2ca20c3), [`eb5c973`](eb5c973)]: - @sveltejs/kit@3.0.0-next.12 ## @sveltejs/adapter-vercel@7.0.0-next.3 ### Patch Changes - fix: await `init` on every request to prevent race condition ([#16467](#16467)) - chore: bump Rolldown to `1.2.0` ([#16455](#16455)) - Updated dependencies [[`adc4c5b`](adc4c5b), [`ecb0701`](ecb0701), [`4b4cc60`](4b4cc60), [`7390dbe`](7390dbe), [`2e71340`](2e71340), [`c87bc3a`](c87bc3a), [`af15c6c`](af15c6c), [`c6fa431`](c6fa431), [`bfe4dea`](bfe4dea), [`df7dc72`](df7dc72), [`5ae11a1`](5ae11a1), [`781205c`](781205c), [`c87bc3a`](c87bc3a), [`a1bfeb9`](a1bfeb9), [`c87bc3a`](c87bc3a), [`9f0127d`](9f0127d), [`4b4cc60`](4b4cc60), [`8f5b9c7`](8f5b9c7), [`c9b5544`](c9b5544), [`fe1d4a4`](fe1d4a4), [`4b4cc60`](4b4cc60), [`5f78e95`](5f78e95), [`25510fc`](25510fc), [`c99a6cf`](c99a6cf), [`17a45ca`](17a45ca), [`2ca20c3`](2ca20c3), [`eb5c973`](eb5c973)]: - @sveltejs/kit@3.0.0-next.12 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

feat: make $app/paths importable in service workers

eb484bc

vercel Bot reviewed Jul 20, 2026

View reviewed changes

Comment thread packages/kit/src/runtime/app/paths/internal/client.js

Comment thread packages/kit/test/apps/options-2/src/service-worker.js

vercel Bot and others added 3 commits July 20, 2026 18:55

wtf

9267dc3

elliott-with-the-longest-name-on-github approved these changes Jul 20, 2026

View reviewed changes

Rich-Harris merged commit df7dc72 into version-3 Jul 20, 2026
21 checks passed

Rich-Harris deleted the service-worker-paths branch July 20, 2026 21:16

github-actions Bot mentioned this pull request Jul 20, 2026

Version Packages (next) #16435

Merged

Navigation Menu

Uh oh!

Uh oh!

feat: make `$app/paths` importable in service workers - #16441

feat: make `$app/paths` importable in service workers#16441
Rich-Harris merged 4 commits into
version-3from
service-worker-paths

Rich-Harris commented Jul 20, 2026

Uh oh!

pkg-svelte-dev Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

svelte-docs-bot Bot commented Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Rich-Harris commented Jul 20, 2026

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

pkg-svelte-dev Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

svelte-docs-bot Bot commented Jul 20, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

pkg-svelte-dev Bot commented Jul 20, 2026 •

edited

Loading

changeset-bot Bot commented Jul 20, 2026 •

edited

Loading