feat: pass the source file name to the preload filter for fonts - #16443
Merged
Rich-Harris merged 8 commits intoAug 19, 2026
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1a83c001ff3fd063174e3b2b298eea993286989bOpen in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
🦋 Changeset detectedLatest commit: 1a83c00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
force-pushed
the
feat-preload-font-name
branch
4 times, most recently
from
July 20, 2026 19:47
274fa31 to
be0eacd
Compare
Nic-Polumeyv
marked this pull request as ready for review
July 20, 2026 19:47
6 tasks
elliott-with-the-longest-name-on-github
pushed a commit
that referenced
this pull request
Jul 20, 2026
extracts the drive-by improvements in #16443 to reduce the size of that diff (am weighing a slightly different approach, but this change unambiguously makes sense) --------- Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Contributor
Author
|
Merged #16445 back in, the diff is feature-only now. |
name to the preload filter for fonts and assetsname to the preload filter for fonts
Contributor
Author
|
Reworked, |
Assets are emitted as `[name].[hash][extname]`, so the source file name can be recovered from the output path without a manifest lookup. The font and modulepreload paths each branched on `link_header_preload` themselves; a Link header value is the `<link>` attribute list joined with `; ` plus `nopush`, so one helper now covers both.
Nic-Polumeyv
force-pushed
the
feat-preload-font-name
branch
from
August 12, 2026 21:05
0f6fcc8 to
f21575c
Compare
Rich-Harris
approved these changes
Aug 18, 2026
Rich-Harris
left a comment
Member
There was a problem hiding this comment.
tweaked it so that it's the project relative filename rather than just the base name — allows for things like filename.includes('@fontsource') and so on
Nic-Polumeyv
added a commit
to Nic-Polumeyv/kit
that referenced
this pull request
Aug 25, 2026
Rich-Harris
added a commit
that referenced
this pull request
Aug 27, 2026
The docs say to opt fonts into preloading with a `preload` filter but not what to match against, so what everyone writes is a substring check against the hashed output path, which silently stops matching when the font is renamed. #16443 added `filename` for this; this shows it. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
nameproperty from #16424 (comment).nameis looked up from the Vite client manifest where the fonts arrays are built, so the filter receives the exact source file name. Deriving it from the emitted path was wrong two ways, the bundler sanitizes characters (inter+bold.woff2is emitted asinter_bold.<hash>.woff2) and content-identical assets are emitted once under a single name. The union includesnameforfontonly, kit never callspreloadwith typeasset.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits