Skip to content

chore: bump deps - #16538

Merged
teemingc merged 5 commits into
version-3from
bump-deps
Jul 27, 2026
Merged

chore: bump deps#16538
teemingc merged 5 commits into
version-3from
bump-deps

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

just trying to silence those pnpm audit warnings

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 27, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from bd39e71:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/bd39e711757b993e145c89a79ff39337ee3e55f1

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16538

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: bd39e71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

Comment thread pnpm-workspace.yaml
@teemingc

Copy link
Copy Markdown
Member

/autofix

Co-authored-by: Tee Ming <chewteeming01@gmail.com>
@teemingc

Copy link
Copy Markdown
Member

/autofix

@teemingc

Copy link
Copy Markdown
Member

Playwright 1.62.0 doesn't seem to like our $app/types extend setting so I've pinned it to 1.61.1 for now

❯ pnpm test:build
$ node test/setup.js && PUBLIC_PRERENDERING=false playwright test
Error: Failed to load tsconfig file at /Users/teeming/git/sveltejs/kit-2/packages/kit/test/apps/basics/tsconfig.json:
Failed to resolve "extends" path "$app/tsconfig" referenced from /Users/teeming/git/sveltejs/kit-2/packages/kit/test/apps/basics/tsconfig.json
    at loadTsConfig (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:792:11)
    at loadAndValidateTsconfigsForFolder (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1021:24)
    at loadAndValidateTsconfigsForFile (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1005:10)
    at resolveHook (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1048:21)
    at resolve (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:862:22)
    at nextStep (node:internal/modules/customization_hooks:189:26)
    at resolveWithHooks (node:internal/modules/customization_hooks:417:10)
    at ModuleLoader.resolveSync (node:internal/modules/esm/loader:747:16)
    at ModuleLoader.#resolve (node:internal/modules/esm/loader:683:17)
    at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:603:35)
    at ModuleJob.syncLink (node:internal/modules/esm/module_job:163:33)
    at ModuleJob.link (node:internal/modules/esm/module_job:253:17)
    at new ModuleJob (node:internal/modules/esm/module_job:232:26)
    at ModuleLoader.#getOrCreateModuleJobAfterResolve (node:internal/modules/esm/loader:572:11)
    at afterResolve (node:internal/modules/esm/loader:607:52)
    at ModuleLoader.getOrCreateModuleJob (node:internal/modules/esm/loader:613:12)
    at node:internal/modules/esm/loader:632:32
    at TracingChannel.tracePromise (node:diagnostics_channel:362:14)
    at ModuleLoader.import (node:internal/modules/esm/loader:628:21)
    at defaultImportModuleDynamicallyForScript (node:internal/modules/esm/utils:239:31)
    at importModuleDynamicallyCallback (node:internal/modules/esm/utils:263:12)
    at eval (eval at esmImport (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1135:29), <anonymous>:1:1)
    at esmImport (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1135:29)
    at requireOrImport (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1139:18)
    at loadUserConfig (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1326:52)
    at loadConfig (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1333:28)
    at Object.loadConfigFromFile (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/common/index.js:1549:10)
    at runTests (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/cli/testActions.js:46:18)
    at _Command.<anonymous> (/Users/teeming/git/sveltejs/kit-2/node_modules/.pnpm/playwright@1.62.0/node_modules/playwright/lib/program.js:55:7)
[ELIFECYCLE] Command failed with exit code 1.

Relevant playwright code is at https://github.com/microsoft/playwright/blob/v1.62.0/packages/playwright/src/transform/tsconfig-loader.ts#L54 which strangely existed prior to 1.62.0 but didn't cause an issue

@teemingc
teemingc merged commit edda4e8 into version-3 Jul 27, 2026
21 checks passed
@teemingc
teemingc deleted the bump-deps branch July 27, 2026 14:31
Rich-Harris pushed a commit that referenced this pull request Jul 30, 2026
#16589)

Neat little find

The cause of [the playwright
pin](#16538 (comment))
is that [its tsconfig
loader](https://github.com/microsoft/playwright/blob/v1.62.0/packages/playwright/src/transform/tsconfig-loader.ts#L54)
only ever looks up `node_modules/$app/tsconfig.json`, while [tsc also
resolves](https://www.typescriptlang.org/tsconfig/#extends) the
directory form we currently generate. Writing the file where both look
removes the pin's cause and lets `paths` reach Playwright test files
again. Verified against 1.61.1, 1.62.0 and 1.62.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants