fix: add a default `"include": []` array to generated tsconfig.json, and warn if not populated by user config by Rich-Harris · Pull Request #16593 · sveltejs/kit

Rich-Harris · 2026-07-30T22:05:18Z

closes #16581

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

…and warn if not populated by user config

pkg-svelte-dev · 2026-07-30T22:05:21Z

Install the latest version of @sveltejs/kit from 150c8a1:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/150c8a11e313b94ad00cbf86d501aab20d50bf54

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16593

changeset-bot · 2026-07-30T22:05:23Z

🦋 Changeset detected

Latest commit: 150c8a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/kit	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

svelte-docs-bot · 2026-07-30T22:08:21Z

Preview: https://svelte-dev-git-preview-kit-16593-svelte.vercel.app/

Conduitry · 2026-07-30T23:32:08Z

+		const resolved = ts.parseJsonConfigFileContent(user_config.options, ts.sys, dir);
+		const warnings = validate_resolved_config(resolved.options, config.compilerOptions);
+
+		if (resolved.raw.include?.length === 0) {


If it's completely missing, this would evaluate to undefined, which doesn't equal 0 - right? Should we just have !resolved.raw.include?.length?

Or is this going to be inheriting from the generated one, which has []? In which case, why the ?.? Is it just because the types can't know that?

it's intentional — if include is unspecified, everything inside the directory containing the tsconfig.json is included. if it's specified-but-empty, as is the case for a user config that extends $app/tsconfig, nothing will be included. i guess this could be clearer

Suggested change

if (resolved.raw.include?.length === 0) {

// `$app/tsconfig` specifies `include: []` — if the user config doesn't override this,

// nothing will be included. `$app/tsconfig/service-worker` doesn't specify `include`,

// which is fine — everything in `src/service-worker` is included by default.

// this warns on `[]`, but ignores `undefined`

if (resolved.raw.include?.length === 0) {

dummdidumm · 2026-07-31T06:08:02Z

+		const warnings = validate_resolved_config(resolved.options, config.compilerOptions);
+
+		if (resolved.raw.include?.length === 0) {
+			warnings.push(`Missing "include" array`);


This message is not providing enough context and needs actionable advice.

And why do we not do src, test ourselves?

Might be because the user should specify those themselves in the root tsconfig.json. If we did it for them, the moment they add a new entry to their root include, it overrides what we've written. Better that they specify everything themselves and adjust the one include array

Exactly — it's a lot more visible if it's in their own config. Ideally the CLI would put src and test and *.ts in automatically.

What about this?

Suggested change

warnings.push(`Missing "include" array`);

warnings.push(`Missing "include" array. Consider adding \`"include": ["src", "test", "*"]\``);

Or more verbosely:

Suggested change

warnings.push(`Missing "include" array`);

warnings.push(`Missing "include" array, which means nothing will be typechecked. Consider adding \`"include": ["src", "test", "*"]\``);

(Trying to avoid making things too verbose, because the text wraps in an ugly awkward way if it takes multiple lines)

The first is better because technically everything will get type checked when it's missing. Like if you did a build it would type check your build output files. Maybe we can swap the "*" with a "your-directory" or "your-file"

extracting the test `tsconfig.json` changes out of #16593 so I can put up an alternative PR without duplicating all that noise

Rich-Harris · 2026-08-04T19:41:14Z

gonna close this in favour of #16645, which I think is a better solution

closes #16581. Different approach to #16593 — rather than adding an empty `include` array from the generated `tsconfig.json`, we just get rid of the `exclude` array and validate the result. This removes a layer of magic and makes it easier for the user to understand the shape of their config. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed. --------- Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com> Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com> Co-authored-by: Nic Polumeyv <nicolas.polum@outlook.com>

fix: add a default "include": [] array to generated tsconfig.json, …

ce1e428

…and warn if not populated by user config

fix tsconfigs

f387410

Conduitry reviewed Jul 30, 2026

View reviewed changes

dummdidumm reviewed Jul 31, 2026

View reviewed changes

teemingc added needs-ecosystem-ci This PR needs to have an ecosystem CI run started prior to its last commit before merging. and removed needs-ecosystem-ci This PR needs to have an ecosystem CI run started prior to its last commit before merging. labels Aug 4, 2026

Rich-Harris mentioned this pull request Aug 4, 2026

chore: update tsconfigs #16644

Merged

Rich-Harris added a commit that referenced this pull request Aug 4, 2026

chore: update tsconfigs (#16644)

a1d7346

extracting the test `tsconfig.json` changes out of #16593 so I can put up an alternative PR without duplicating all that noise

Merge branch 'version-3' into tsconfig-include-empty

150c8a1

This was referenced Aug 4, 2026

tsconfig exclude node_modules #16581

Closed

feat: warn when tsconfig doesn't exclude service worker #16645

Merged

Rich-Harris closed this Aug 4, 2026

Navigation Menu

Uh oh!

Uh oh!

fix: add a default `"include": []` array to generated tsconfig.json, and warn if not populated by user config - #16593

fix: add a default `"include": []` array to generated tsconfig.json, and warn if not populated by user config#16593
Rich-Harris wants to merge 3 commits into
version-3from
tsconfig-include-empty

Rich-Harris commented Jul 30, 2026

Uh oh!

pkg-svelte-dev Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 30, 2026 •

edited

Loading

Uh oh!

svelte-docs-bot Bot commented Jul 30, 2026

Uh oh!

Conduitry Jul 30, 2026

Uh oh!

Conduitry Jul 30, 2026

Uh oh!

Rich-Harris Jul 31, 2026

Uh oh!

dummdidumm Jul 31, 2026

Uh oh!

teemingc Jul 31, 2026

Uh oh!

Rich-Harris Jul 31, 2026

Uh oh!

Rich-Harris Jul 31, 2026

Uh oh!

teemingc Jul 31, 2026 •

edited

Loading

Uh oh!

Rich-Harris commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-		if (resolved.raw.include?.length === 0) {
+		// `$app/tsconfig` specifies `include: []` — if the user config doesn't override this,
+		// nothing will be included. `$app/tsconfig/service-worker` doesn't specify `include`,
+		// which is fine — everything in `src/service-worker` is included by default.
+		// this warns on `[]`, but ignores `undefined`
+		if (resolved.raw.include?.length === 0) {

	warnings.push(`Missing "include" array`);
	warnings.push(`Missing "include" array. Consider adding \`"include": ["src", "test", "*"]\``);

	warnings.push(`Missing "include" array`);
	warnings.push(`Missing "include" array, which means nothing will be typechecked. Consider adding \`"include": ["src", "test", "*"]\``);

Uh oh!

Uh oh!

Conversation

Rich-Harris commented Jul 30, 2026

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

pkg-svelte-dev Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

svelte-docs-bot Bot commented Jul 30, 2026

Uh oh!

Conduitry Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Conduitry Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Rich-Harris Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

dummdidumm Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

teemingc Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Rich-Harris Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

Rich-Harris Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

teemingc Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Rich-Harris commented Aug 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pkg-svelte-dev Bot commented Jul 30, 2026 •

edited

Loading

changeset-bot Bot commented Jul 30, 2026 •

edited

Loading

teemingc Jul 31, 2026 •

edited

Loading