Skip to content

fix: stream promised read results lazily #16622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 2 commits into from
Aug 3, 2026
Merged

fix: stream promised read results lazily #16622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d26ff54
fix: stream promised read results lazily
Nic-Polumeyv Aug 3, 2026
b688257
Merge branch 'version-3' into wrapped-read-stream
teemingc Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/wise-moons-read.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: stream promised `read` results lazily instead of eagerly buffering them
34 changes: 10 additions & 24 deletions packages/kit/src/runtime/server/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,31 +67,17 @@ export class Server {
const result = read(file);
if (result instanceof ReadableStream) {
return result;
} else {
return new ReadableStream({
async start(controller) {
try {
const stream = await Promise.resolve(result);
if (!stream) {
controller.close();
return;
}

const reader = stream.getReader();

while (true) {
const { done, value } = await reader.read();
if (done) break;
controller.enqueue(value);
}

controller.close();
} catch (error) {
controller.error(error);
}
}
});
}

// TODO remove the cast once TypeScript's lib includes `ReadableStream.from`
Comment thread
vercel[bot] marked this conversation as resolved.
return /** @type {ReadableStream} */ (
/** @type {any} */ (ReadableStream).from(
(async function* () {
const stream = await result;
if (stream) yield* stream;
})()
)
);
};

set_read_implementation(wrapped_read);
Expand Down
Loading