Skip to content

chore: centralise transport stuff - #16658

Merged
elliott-with-the-longest-name-on-github merged 13 commits into
version-3from
init-transport
Aug 5, 2026
Merged

chore: centralise transport stuff#16658
elliott-with-the-longest-name-on-github merged 13 commits into
version-3from
init-transport

Conversation

@Rich-Harris

@Rich-Harris Rich-Harris commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This is #16406 but takes the idea to its logical conclusion: by having an internal module where this stuff is managed, we don't need to pass anything around at all and can delete/simplify a bunch of stuff. Once this is in, will rebase #14129 against version-3 and update it to use this.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 8170969:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8170969f7b88d0a70361fa238e47b02ee2651980

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16658

@changeset-bot

changeset-bot Bot commented Aug 5, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8170969

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

svelte-docs-bot Bot commented Aug 5, 2026

Copy link
Copy Markdown

Preview: https://svelte-dev-git-preview-kit-16658-svelte.vercel.app/

@Rich-Harris
Rich-Harris marked this pull request as ready for review August 5, 2026 15:48
@Rich-Harris Rich-Harris mentioned this pull request Aug 5, 2026
Closed
6 tasks
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github reviewed Aug 5, 2026
View reviewed changes

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits but overall this looks great, much better than our previous attempts

Comment thread packages/kit/src/runtime/app/internal/transport.js Outdated
Comment thread packages/kit/src/runtime/app/forms.js
Comment on lines -41 to -42
// the decoders should never be initialised at the top-level because `app`
// will not be initialised yet if `output.bundleStrategy` is 'single' or 'inline'

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bookmark for me: does this still affect us?

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github Aug 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess not because we're init-ing in _start?

@Rich-Harris Rich-Harris Aug 5, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah should be fine I think

Comment thread packages/kit/src/runtime/server/page/data_serializer.js
@Rich-Harris @elliott-with-the-longest-name-on-github
Update packages/kit/src/runtime/app/internal/transport.js
8170969 
Co-authored-by: Elliott Johnson <hello@ell.iott.dev>
@elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github merged commit f150b20 into version-3 Aug 5, 2026
26 checks passed
@Nic-Polumeyv Nic-Polumeyv mentioned this pull request Aug 6, 2026
Merged
Rich-Harris pushed a commit that referenced this pull request Aug 8, 2026
@Nic-Polumeyv
chore: import record_span directly instead of passing it through state (
a343c23 
#16675)

Follow-up to
#16605 (comment), using
the #16658 treatment so it works from `sequence`. On top of #16605.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Rich-Harris @elliott-with-the-longest-name-on-github