breaking: move defineParams and associated types to @sveltejs/kit/params - #16716
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/351add9a39d3e651b666bfeed0f2d3113ff950e5Open in |
🦋 Changeset detectedLatest commit: 351add9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
|
|
||
| /** | ||
| * @param {import('@sveltejs/kit').ParamDefinition} definition |
Contributor
Contributor
There was a problem hiding this comment.
are you reviewing the deleted code??
elliott-with-the-longest-name-on-github
approved these changes
Aug 10, 2026
| } | ||
|
|
||
| /** | ||
| * @param {import('@sveltejs/kit').ParamDefinition} definition |
Contributor
There was a problem hiding this comment.
are you reviewing the deleted code??
Contributor
|
something small is very broken but overall looks good |
6 tasks
teemingc
pushed a commit
that referenced
this pull request
Aug 11, 2026
version-3 lint-all is red since #16716. The new `@sveltejs/kit/params` module was missing from the tsconfig `paths` map, and one import still pointed at the old location. ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
teemingc
added a commit
that referenced
this pull request
Aug 11, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.19 ### Major Changes - breaking: move `defineParams` and associated types to `@sveltejs/kit/params` ([#16716](#16716)) - breaking: run all errors through the `handleError` hook ([#16664](#16664)) - breaking: move `Page`, `ReadonlyURL` and `ReadonlyURLSearchParams` from `@sveltejs/kit` to `$app/state` ([#16694](#16694)) - breaking: move `BeforeNavigate`, `OnNavigate`, `AfterNavigate`, `Navigation`, `NavigationTarget`, `NavigationType`, `GotoOptions` and the `Navigation*` variant types from `@sveltejs/kit` to `$app/navigation` ([#16694](#16694)) - breaking: move `ActionResult` and `SubmitFunction` from `@sveltejs/kit` to `$app/forms` ([#16694](#16694)) - breaking: remove `handleValidationError` and pass remote function validation errors to `handleError` with `kind: 'validation'` ([#16672](#16672)) ### Minor Changes - feat: ignore files with + prefix if they contain test/spec/stories ([#16715](#16715)) ### Patch Changes - fix: rebuild the dev manifest when route files disappear during an incremental update ([#16643](#16643)) - fix: externalize `@opentelemetry/api` to prevent bundler chunk colocation between `instrumentation.server.js` and application code ([#16302](#16302)) - fix: surface prerender errors during development ([#16507](#16507)) ## @sveltejs/adapter-node@6.0.0-next.9 ### Patch Changes - fix: externalize `@opentelemetry/api` to prevent bundler chunk colocation between `instrumentation.server.js` and application code ([#16302](#16302)) - Updated dependencies [[`04f9ab4`](04f9ab4), [`1e198bd`](1e198bd), [`813726d`](813726d), [`a115a7b`](a115a7b), [`031ac69`](031ac69), [`dc7442c`](dc7442c), [`19c4478`](19c4478), [`dc7442c`](dc7442c), [`dc7442c`](dc7442c), [`0b3e2b3`](0b3e2b3)]: - @sveltejs/kit@3.0.0-next.19 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Tee Ming <chewteeming01@gmail.com>
teemingc
pushed a commit
that referenced
this pull request
Aug 11, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/kit@3.0.0-next.19 ### Major Changes - breaking: move `defineParams` and associated types to `@sveltejs/kit/params` ([#16716](#16716)) - breaking: run all errors through the `handleError` hook ([#16664](#16664)) - breaking: move `Page`, `ReadonlyURL` and `ReadonlyURLSearchParams` from `@sveltejs/kit` to `$app/state` ([#16694](#16694)) - breaking: move `BeforeNavigate`, `OnNavigate`, `AfterNavigate`, `Navigation`, `NavigationTarget`, `NavigationType`, `GotoOptions` and the `Navigation*` variant types from `@sveltejs/kit` to `$app/navigation` ([#16694](#16694)) - breaking: move `ActionResult` and `SubmitFunction` from `@sveltejs/kit` to `$app/forms` ([#16694](#16694)) - breaking: remove `handleValidationError` and pass remote function validation errors to `handleError` with `kind: 'validation'` ([#16672](#16672)) ### Minor Changes - feat: ignore files with + prefix if they contain test/spec/stories ([#16715](#16715)) ### Patch Changes - fix: rebuild the dev manifest when route files disappear during an incremental update ([#16643](#16643)) - fix: externalize `@opentelemetry/api` to prevent bundler chunk colocation between `instrumentation.server.js` and application code ([#16302](#16302)) - fix: surface prerender errors during development ([#16507](#16507)) - fix: adjust error overload for optional `App.Error` parameters ([#16725](#16725)) ## @sveltejs/adapter-node@6.0.0-next.9 ### Patch Changes - fix: externalize `@opentelemetry/api` to prevent bundler chunk colocation between `instrumentation.server.js` and application code ([#16302](#16302)) - Updated dependencies [[`04f9ab4`](04f9ab4), [`1e198bd`](1e198bd), [`813726d`](813726d), [`a115a7b`](a115a7b), [`031ac69`](031ac69), [`dc7442c`](dc7442c), [`19c4478`](19c4478), [`dc7442c`](dc7442c), [`dc7442c`](dc7442c), [`0b3e2b3`](0b3e2b3), [`c5d0ce2`](c5d0ce2)]: - @sveltejs/kit@3.0.0-next.19 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #16676
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits