chore: remove prepare scripts - #16729
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/3b8ce3603f1554003d3d8c135501d69d550ddf45Open in |
|
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
teemingc
marked this pull request as draft
August 11, 2026 10:08
teemingc
marked this pull request as ready for review
August 11, 2026 17:16
SobolievOleksii
added a commit
to SobolievOleksii/kit
that referenced
this pull request
Aug 28, 2026
- pnpm-lock.yaml: re-add the fixture importer against the current catalog (vite 8.2.1 / svelte 5.56.8 / vite-plugin-svelte 7.3.0), matching the sibling basic app so no extra package versions enter the lockfile - drop the fixture's prepare script, gone from adapter-node test apps upstream (sveltejs#16729) - tsconfig extends $app/tsconfig instead of ./.svelte-kit/tsconfig.json Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to run all these
preparescripts on everypnpm i. OurcheckCI action already runssvelte-kit syncbefore type checking.This PR removes them and ignores the
postinstallscripts from packages which only use them to emit warnings. Cuts 8s frompnpm ion my M1 Pro;maybe it's a little more in CI for each jobseems to cut about 19 seconds from the install step.