Skip to content

chore: unify walk and list_files - #16784

Merged
Rich-Harris merged 2 commits into
version-3from
unify-walk
Aug 13, 2026
Merged

chore: unify walk and list_files#16784
Rich-Harris merged 2 commits into
version-3from
unify-walk

Conversation

@Nic-Polumeyv

Copy link
Copy Markdown
Contributor

walk in utils/filesystem.js and list_files in core/utils.js were the same recursive walk with minor drift. Merged into one generator that yields posix paths. walk's dirs parameter had no callers.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 13, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 4235f19:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/4235f1936ff8abd55c37f02cbf69a3bdd1016b1c

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16784

@changeset-bot

changeset-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4235f19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Nic-Polumeyv
Nic-Polumeyv changed the base branch from main to version-3 August 13, 2026 19:20
@svelte-docs-bot

Copy link
Copy Markdown

@Rich-Harris
Rich-Harris merged commit 7d78680 into version-3 Aug 13, 2026
27 checks passed
@Rich-Harris
Rich-Harris deleted the unify-walk branch August 13, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants