fix: resolve client manifest imports against Vite root - #16803
Merged
elliott-with-the-longest-name-on-github merged 1 commit intoAug 14, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/6abfa51455996d40a2e462985ac676b3ce2937acOpen in |
🦋 Changeset detectedLatest commit: 6abfa51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
approved these changes
Aug 14, 2026
elliott-with-the-longest-name-on-github
merged commit Aug 14, 2026
fb0e21c
into
version-3
27 checks passed
elliott-with-the-longest-name-on-github
deleted the
fix-client-manifest-vite-root
branch
August 14, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16785
Basically, paths in the manifest are relative to Vite's configured
root, butwrite_client_manifestwas resolving them relative toprocess.cwd(). These are normally the same, but aren't when Vite is started programmatically from another directory, causing the generated client manifest to import route files from the wrong place.Passes the Vite root through to
write_client_manifestand uses it to resolve components, universal modules, and param matchers before generating their imports. Adds a regression test where the project root differs fromprocess.cwd().