fix: only suggest a + prefix for route filenames that are valid with the file's extension - #16837
Merged
Merged
Conversation
…h the file's extension
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/dd8e9083dde899e4c9d5e85ab2bc0b77dde7b3dbOpen in |
🦋 Changeset detectedLatest commit: dd8e908 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_manifest_datawarnsDid you mean +${file.name}?for any file whose name matches either the component or the module grammar, ignoring the extension. Forroutes/a/error.tsit suggests+error.ts, and renaming to that throwsFiles prefixed with + are reserved. The two grammars were also written out three times in the file; they're now two module-level patterns and the typo check picks the one matching the extension.