chore: share navigation completion between navigate and shallow routing - #16838
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/7d6f66e3663a93912051ad8df6cde6ce9fca2a6dOpen in |
🦋 Changeset detectedLatest commit: 7d6f66e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#16449 made shallow
gotorun navigation hooks by copying two blocks out ofnavigateintoupdate_state: theonNavigatecallback run with itsafterNavigateregistration, and the completion tail (abort check, scroll and focus reset,fulfil,to.scroll,afterNavigatecallbacks). #16685 then had to change both copies. They are nowrun_on_navigate_callbacksandfinish_navigation, called from both places. The second commit buildsnavigate's not-found fallback once instead of in two branches that differ only by the message suffix.