chore: iterate the query cache maps through a single generator - #16846
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/9a27d0e659d79015ab65aa9f1a15b5d7a192e6e0Open in |
🦋 Changeset detectedLatest commit: 9a27d0e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Nic-Polumeyv
force-pushed
the
cache-entries-generator
branch
2 times, most recently
from
August 19, 2026 16:29
f8b810f to
9c03493
Compare
Nic-Polumeyv
force-pushed
the
cache-entries-generator
branch
from
August 19, 2026 16:33
9c03493 to
e97f363
Compare
Nic-Polumeyv
force-pushed
the
cache-entries-generator
branch
from
August 19, 2026 16:34
e97f363 to
9a27d0e
Compare
Rich-Harris
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
client.jswalksquery_mapandlive_query_mapeight times across_invalidateand_goto, each as a hand-writtenfor (const [id, entries] of map) for (const [payload, entry] of entries)pair, and five of those recomputecreate_remote_key(id, payload)inline to get the key the consumer actually wants.This adds a
cache_entries(map)generator yielding[key, entry]and collapses each site to a single loop. No behaviour change; the walk order and the set of resources touched are identical.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.