breaking: replace the generateManifest adapter api again - #16875
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8d7123e1bea2e527d8e6841be165ad0f76defb50Open in |
🦋 Changeset detectedLatest commit: 8d7123e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
I had AI write these for me, since I wanted to quickly review this, but the issues are my findings, just might be a bit wordy.
The adapter-node build failure is the blocker (first comment, reproduced on 1a17e1f; the suggested change builds and passes the adapter-node tests). The service-worker, mime and $-substitution comments share a cause: builder.manifest and builder.mimeTypes are computed from manifest_data while the generated entry's manifest gets the augmented versions from generate_manifest, so every adapter that switched to the builder getters lost something. Computing both from the same data as generate_manifest fixes all three without exposing the manifest to adapters.
96706ef to
86a705e
Compare
b6349fd to
87a85c4
Compare
f33d358 to
4b231f3
Compare
There was a problem hiding this comment.
If not in a follow up PR, can we talk about the breaking change in https://next.svelte.dev/docs/kit/migrating-to-sveltekit-3#Adapters (documentation/docs/60-appendix/35-migrating-to-sveltekit-3.md) ?
|
/autofix |
…rEntrypoint` and `builder.manifest`
25058a9 to
5ec53b0
Compare
We want `SSRManifest` to be an internal implementation detail rather than a public type that has to remain stable. #16875 removes all adapter uses of `SSRManifest`, this PR moves it to `internal.d.ts`. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. ### Tests - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. --- <sub>Stack created with <a href="https://github.com/github/gh-stack">GitHub Stacks CLI</a> • <a href="https://gh.io/stacks-feedback">Give Feedback 💬</a></sub>
breaking #16843 into smaller pieces
This PR just removes all adapter code that accesses SSRManifest. #16876 is stacked on top of this and actually makes
SSRManifestprivate, which is the end goal.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.