Skip to content

test: wait for beforeNavigate redirect state - #16891

Merged
Rich-Harris merged 1 commit into
version-3from
flake/kit-pr-16880-before-navigate-redirect-wait
Aug 26, 2026
Merged

test: wait for beforeNavigate redirect state#16891
Rich-Harris merged 1 commit into
version-3from
flake/kit-pr-16880-before-navigate-redirect-wait

Conversation

@svelte-triage-bot

Copy link
Copy Markdown
Contributor

Fixes a pre-existing Playwright synchronization race found while investigating sveltejs/kit#16880 and its failed workflow run.

page.waitForLoadState('networkidle') could return immediately because network idle had already been reached before the client-side redirect navigation. The following raw DOM read could then observe stale state. Replace it with a web-first toHaveText assertion that waits for the expected navigation callback state.

Verification included 100 repetitions with four workers, the complete client spec, the original 4-worker shard, and server/client route-resolution variants. This is test-only, so no changeset is included.

@pkg-svelte-dev

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 37b3bed:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/37b3bedda76681d1e0be7e65e1cc10a4dc3f8e34

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16891

Note

This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed.

@changeset-bot

changeset-bot Bot commented Aug 21, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 37b3bed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Rich-Harris marked this pull request as ready for review August 26, 2026 17:33
@Rich-Harris
Rich-Harris merged commit 47e2a06 into sveltejs:version-3 Aug 26, 2026
67 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants