test: wait for beforeNavigate redirect state - #16891
Merged
Rich-Harris merged 1 commit intoAug 26, 2026
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/37b3bedda76681d1e0be7e65e1cc10a4dc3f8e34Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
|
elliott-with-the-longest-name-on-github
approved these changes
Aug 21, 2026
Rich-Harris
marked this pull request as ready for review
August 26, 2026 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a pre-existing Playwright synchronization race found while investigating sveltejs/kit#16880 and its failed workflow run.
page.waitForLoadState('networkidle')could return immediately because network idle had already been reached before the client-side redirect navigation. The following raw DOM read could then observe stale state. Replace it with a web-firsttoHaveTextassertion that waits for the expected navigation callback state.Verification included 100 repetitions with four workers, the complete client spec, the original 4-worker shard, and server/client route-resolution variants. This is test-only, so no changeset is included.