fix: widen remote form field types - #16937
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/8e0ee5ec6ff170476c515959c78bbad43f9c1958Open in |
🦋 Changeset detectedLatest commit: 8e0ee5e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
teemingc
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #16931
Union fields
Given a schema like
{ a: string } | { b: string },form.fieldswas typed as{ a: RemoteFormField<string> } | { b: RemoteFormField<string> }. That meant neitherform.fields.anorform.fields.bcould be accessed, even though both fields exist on the runtime proxy:This preserves the original input union in a tuple so the outer conditional does not distribute over it, then deliberately collects the keys from every union member for the form instance. The container methods still use the original union, while the instance exposes both
aandb; unknown fields remain errors.Enum fields
A string enum field kept its literal union in the attributes returned by
.as(...), which made an otherwise valid spread fail type checking:This widens literal strings to
stringonly in the returned DOM-facingvalueproperty. The.as(...)arguments still use the original enum, sochoice.as('text', 'three')remains an error for a'one' | 'two'field.Both cases have focused type regression tests.