test: wait for cancelled popstate navigation - #16945
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/d9ec6235fdf843adf3c03fc712b0b99be7d65ad7Open in Note This PR is from a fork. A maintainer must approve approve each commit before it can be built and installed. |
6 tasks
|
Rich-Harris
approved these changes
Aug 26, 2026
Rich-Harris
marked this pull request as ready for review
August 26, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky navigation lifecycle test observed in PR #16900 and CI run 32992201226.
When a popstate navigation is cancelled, SvelteKit performs a compensating history traversal.
page.goBack()can resolve before that traversal and the resulting reactive DOM update have settled, causing the test to read the initial state. Use Playwright web-first assertions for both the rendered navigation state and restored URL.Verification: