fix: stop adapter-vercel tracing from globbing the whole drive on Windows - #16972
Merged
Conversation
…ob from the filesystem root
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1f04ce6ab7a0ed5d2fa7c777217cc60089358c13Open in |
🦋 Changeset detectedLatest commit: 1f04ce6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
approved these changes
Aug 28, 2026
|
I am weirdly very happy to know I wasn't doing anything wrong. Thank you very much for getting this patch in this fast! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_function_bundletraces withbaseset to the filesystem root. nft treats any absolute-looking string with a dynamic segment as an asset glob, and the server output has URL strings likeOn Linux this resolves to
/<*>/routes, the parent directory is'', the stat fails and nothing happens. On Windows it resolves toD:\<*>\routes, the parentD:stats fine, and nft runsglob('D:/**/*/routes')over the whole drive, which never finishes once it hitspagefile.sys.nft also evaluates
process.cwd()asbaseunless told otherwise, sopath.join(process.cwd(), 'asset.txt')was traced from/and never bundled.nft calls
ignorewith the glob relative tobasebefore walking, and a base-rooted glob is**\*\routes. The cwd case has a regression test; the root-glob case can't fire on Linux for the reason above.Fixes #16963. Supersedes #16964. Related: vercel/nft#609.