Skip to content

chore: use correct Vite instance for runner checks - #16973

Open
teemingc wants to merge 3 commits into
version-3from
teemingc-fix-vite-runner-detection
Open

chore: use correct Vite instance for runner checks#16973
teemingc wants to merge 3 commits into
version-3from
teemingc-fix-vite-runner-detection

Conversation

@teemingc

@teemingc teemingc commented Aug 28, 2026

Copy link
Copy Markdown
Member

fixes the vite ecosystem ci error https://github.com/vitejs/vite-ecosystem-ci/actions/runs/32693769091/job/97332021820#step:7:1811

There is no point to us calling resolve_peer(...) for a Vite instance in the vite/index.js file anymore since we don't use to run the client build during a server build (SvelteKit 2 behaviour). Removing this should avoid the vite-ecosystem-ci error where the Vite runner instanceof check fails from two differently resolved Vite instances (the one that started the build and the one from our resolve_peer).

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4e6f844

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-svelte-dev

pkg-svelte-dev Bot commented Aug 28, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 4e6f844:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/4e6f8446c6ed2313ae880c7e0bc6f0d405629498

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16973

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc teemingc changed the title fix: use command Vite instance for runner checks chore: use correct Vite instance for runner checks Aug 28, 2026
Comment thread packages/kit/types/index.d.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant