Skip to content

Warn about incorrect data-sveltekit-x values - #6546

Merged
Rich-Harris merged 4 commits into
masterfrom
gh-6532
Sep 3, 2022
Merged

Warn about incorrect data-sveltekit-x values#6546
Rich-Harris merged 4 commits into
masterfrom
gh-6532

Conversation

@Rich-Harris

Copy link
Copy Markdown
Member

#6532. This updates the docs to clarify that data-sveltekit-prefetch and data-sveltekit-prefetch="" are equivalent, and also adds console errors at dev time if you pass an incorrect value.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot

changeset-bot Bot commented Sep 3, 2022

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7e0d2a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify

netlify Bot commented Sep 3, 2022

Copy link
Copy Markdown

Deploy Preview for kit-demo ready!

Name Link
🔨 Latest commit 7e0d2a5
🔍 Latest deploy log https://app.netlify.com/sites/kit-demo/deploys/631351349b67110008811915
😎 Deploy Preview https://deploy-preview-6546--kit-demo.netlify.app/build
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Rich-Harris
Rich-Harris merged commit 3f31d70 into master Sep 3, 2022
@Rich-Harris
Rich-Harris deleted the gh-6532 branch September 3, 2022 21:24
@github-actions github-actions Bot mentioned this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants