[fix] parsing content-type header for actions - #7195
Merged
dummdidumm merged 7 commits intoOct 10, 2022
Conversation
🦋 Changeset detectedLatest commit: c4f84f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Did you see the note from @Conduitry about making sure we're doing this for CSRF? I haven't looked yet to see if any changes are necessary -- just want to leave this not as a "TODO". |
Contributor
Author
|
I saw this note, but I don't see how CSRF can be related to incorrect header parsing. |
dummdidumm
approved these changes
Oct 10, 2022
dummdidumm
left a comment
Member
There was a problem hiding this comment.
The joys of coding with the VS Code web extension without any intellisense 😄
Rich-Harris
added a commit
that referenced
this pull request
Jul 30, 2026
…arset parameter (#16567) The prerenderer compares `content-type` with `===`, so `text/html; charset=utf-8` is not treated as HTML: the page is written without a `.html` extension and its links are never crawled. `is_content_type` already normalizes the header for this reason, from #7195 (strip parameters) and GHSA-gv7g-x59x-wf8f (case-insensitive compare); the two prerender checks predate both. Reproduces #13612, closed as unreproducible, using the charset workaround from #3184. The root `+server.js` error added in #15994 is gated on the same value, so it can fire for an app that has none. Co-authored-by: Nic Polumeyv <nicolas.polum@gmail.com> Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7187
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0