Read mode/credentials from init object, not request - #7453
Merged
Conversation
🦋 Changeset detectedLatest commit: 06a5cf6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
approved these changes
Oct 31, 2022
dummdidumm
left a comment
Member
There was a problem hiding this comment.
I'd say we go with this first and then see how often it comes up afterwards? We can always add the other PR on top/instead later on.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #7192. Rather than checking for a
cfproperty, it readsmodeandcredentialsfrom the second argument passed tofetch, unlessfetchwas called with aRequestobject (which is a somewhat unusual case; code that doesfetch(request)would have to be refactored tofetch(url, init)on Cloudflare).I'm slightly ambivalent about which approach is better. This gets rid of the Cloudflare-specific
cfstuff, and in theory is more resilient to other runtimes doing the same thing, but it would force the aforementioned refactoring in a very small minority of cases.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0