fix: adjust app.d.ts to diminish confusion about imports - #8477
Merged
Conversation
🦋 Changeset detectedLatest commit: 5c55377 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
force-pushed
the
ambient-stuff
branch
from
January 12, 2023 11:02
321b597 to
0cf7851
Compare
Rich-Harris
requested changes
Jan 13, 2023
Rich-Harris
left a comment
Member
There was a problem hiding this comment.
Pleasantly surprised to discover that export declare works — solves the problem without export default undefined which is fugly and requires explanation. Unless there's a reason not to use export declare?
Member
Author
|
As discussed offline, |
Rich-Harris
reviewed
Jan 13, 2023
Rich-Harris
approved these changes
Jan 13, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #8276
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.