remove buggy cookie path detection - #9298
Merged
Merged
Conversation
dummdidumm
reviewed
Mar 3, 2023
dummdidumm
left a comment
Member
There was a problem hiding this comment.
I think the problem is not with how we set the incoming cookie, because through cookie.set we can track the path correctly. I think in the case of tests the problem is that we basically track the existing cookie paths in a singleton, which likely spans all Playwright workers. I'm not sure how others run into this, but given the comments in the issue it seems to happen, so I'm ok with removing some these checks.
(I would also remove the comment in line 126/127 because it references the now removed warning from the delete branch)
dummdidumm
approved these changes
Mar 6, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #9130
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.