return 308s instead of 301s when normalising paths - #9351
Merged
Conversation
teemingc
approved these changes
Mar 7, 2023
Merged
Rich-Harris
pushed a commit
that referenced
this pull request
Aug 18, 2026
…ge to the correct trailing slash (#16836) The trailing-slash redirect for prerendered pages in `exports/vite/preview/index.js` writes an absolute `location` from the pathname the middleware sees, but that middleware runs inside `scoped(base, ...)`, which has already stripped `paths.base`. With a base path the browser lands on `/nested/` instead of `/base/nested/`. Production (#9351) and adapter-node (#16431) send a relative location for this reason and use 308; preview now does the same via `relative_pathname`. --------- Co-authored-by: Nic Polumeyv <nicolas.polum@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #9350
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.