test: add hardware wallet e2e on ios#618
Conversation
Greptile SummaryThis PR adds iOS hardware-wallet E2E support. The main changes are:
Confidence Score: 4/5This is close, but the hardware-wallet E2E config should be fixed before merging.
Bitkit/Info.plist and .github/workflows/e2e-tests.yml
|
| Filename | Overview |
|---|---|
| .github/workflows/e2e-tests.yml | Adds Trezor bridge build settings and includes hardware-wallet specs in the local iOS E2E shard. |
| Bitkit/Info.plist | Adds Trezor bridge and Electrum plist keys for hardware-wallet E2E configuration. |
| Bitkit/Views/Settings/General/HardwareWalletsSettingsScreen.swift | Updates hardware-wallet settings identifiers and row interactions for E2E access. |
| Bitkit/Views/Sheets/HardwareConnect/HwFoundView.swift | Renames found-screen accessibility identifiers for the hardware-wallet flow. |
| Bitkit/Views/Sheets/HardwareConnect/HwPairedView.swift | Adds a paired-screen accessibility identifier. |
| Bitkit/Views/Sheets/HardwareConnect/HwSearchingView.swift | Renames searching-screen accessibility identifiers for the hardware-wallet flow. |
| Bitkit/Views/Sheets/HardwareConnectSheet.swift | Renames intro-sheet accessibility identifiers for the hardware-wallet flow. |
| Bitkit/Views/Transfer/Hardware/SpendingAmountHw.swift | Adds an accessibility identifier to the hardware transfer amount screen. |
| Bitkit/Views/Transfer/Hardware/SpendingHwSign.swift | Adds an accessibility identifier to the hardware signing screen. |
| Bitkit/Views/Wallets/HardwareWalletScreen.swift | Adds an accessibility identifier to the hardware wallet screen. |
Reviews (2): Last reviewed commit: "ci: drop trezor image pull from ios e2e" | Re-trigger Greptile
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1081e125c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <key>TREZOR_ELECTRUM_URL</key> | ||
| <string>$(TREZOR_ELECTRUM_URL)</string> |
There was a problem hiding this comment.
The local E2E build now defines TREZOR_BRIDGE and TREZOR_BRIDGE_URL, but this new TREZOR_ELECTRUM_URL plist value has no matching build setting in the workflow. When the app falls back to the plist, the hardware-wallet regtest path can receive the literal $(TREZOR_ELECTRUM_URL) value as its Electrum URL. That leaves bridge-backed hardware-wallet tests able to find the emulator, but unable to sync or sign through the expected regtest Electrum endpoint.
|
Docker pull of trezor emulator is stuck on mac-mini. Needs investigation on mac-mini itself - James will have access to it next week to check. |
Refs #589
This PR:
@hardware_walletspecs into the self-hosted local iOS E2E job (with Trezor emulator image pull), running serially alongside the existing local grep list.Linked Issues/Tasks
Refs #589
Companion PR: synonymdev/bitkit-e2e-tests#195
Screenshot / Video
N/A
QA Notes
Manual Tests
N/A
Automated Checks
actions.tsadds cross-platform id-prefix matching;hardware-wallet.tsfixes rename/delete taps on iOS.@hardware_walletto the existinge2e-tests-localgrep, pulls the Trezor emulator image, and builds withTREZOR_BRIDGE=true/TREZOR_BRIDGE_URL=http://127.0.0.1:21325.BACKEND=local:@hardware_wallet_1,@hardware_wallet_2,@hardware_wallet_3pass.