Skip to content

setup nuxt-picture for guide articles#700

Merged
storyaddict merged 5 commits into
masterfrom
nuxt-image
Jun 24, 2021
Merged

setup nuxt-picture for guide articles#700
storyaddict merged 5 commits into
masterfrom
nuxt-image

Conversation

@btkostner

@btkostner btkostner commented Jun 24, 2021

Copy link
Copy Markdown
Contributor

This replaces images in markdown articles with nuxt-picture which during the build process will resize all pictures, optimize, and create a webp version.

TODO:

  • some image paths are missing

@btkostner

Copy link
Copy Markdown
Contributor Author

@system76/support This fixes all the broken images seen here https://github.com/system76/docs/runs/2901550731?check_suite_focus=true (builds step)

@btkostner
btkostner marked this pull request as ready for review June 24, 2021 16:54
@btkostner
btkostner requested a review from a team June 24, 2021 16:54
@btkostner

Copy link
Copy Markdown
Contributor Author

The two images deleted in the PR are variations of the ones we are actually using in the article, but are not linked from anywhere.

@storyaddict storyaddict left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picture changes look good, nuxt file update accompanies it.

@storyaddict
storyaddict merged commit a883d86 into master Jun 24, 2021
@storyaddict
storyaddict deleted the nuxt-image branch June 24, 2021 21:14
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
setup nuxt-picture for guide articles
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
setup nuxt-picture for guide articles
erinxocon pushed a commit that referenced this pull request Jun 23, 2026
setup nuxt-picture for guide articles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants