Skip to content

create v2.0.6 - #160

Merged
jacalata merged 17 commits into
mainfrom
development
Aug 11, 2022
Merged

create v2.0.6#160
jacalata merged 17 commits into
mainfrom
development

Conversation

@jacalata

Copy link
Copy Markdown
Contributor

Fix get/export
Fix several mis-configured arguments
Fix error handling
Add list "items" command
Change install destination

jacalata and others added 17 commits July 8, 2022 01:24
* configure black
* add step to list dependencies for licensing
* Defect 1427376: [Tabcmd WAM] --save-db-password flag thinks it should get an argument
 -updated several other publishing arguments that had the same problem
- change argument from "token" to "token-value" so it is not a substring of "token-name", remove the 2-letter short arguments
* fix reencrypt_extracts help string
* Hand format a nice help output
* Fix exit_with_error handling
* Defect 1426885: [Tabcmd WAM] addusers and removeusers error
* fix deletegroup
* update unlocalized strings
clearly indicate when using the default site
Getting workbook works as expected, but appends extra file extensions
* Rename src dir to tabcmd so that setup.py install will go to the 'tabcmd' destination directory
* Update references in scripts and code to reflect src-->tabcmd
Defect 1428581: [Tabcmd WAM] Publishing to projects other than default throws an error
* filter for items in project
* separate the use of ds/wb as flags vs as argument names
* update publish_samples to call shared project logic
* Create run-e2-tests.yml

@bcantoni bcantoni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmuttreja-tableau

Copy link
Copy Markdown

Looks good, I compared commits history and briefly ran through. Is the version tag only at pypi stage? Do we do something like this ?
I ran code coverage, and some files seem low, can we get everything to around 80% code coverage (maybe a future MR?).

@jacalata

Copy link
Copy Markdown
Contributor Author
  • yes, versioning uses setuptools_scm and the _version.py file (see this CL)

  • yes, it's low in a couple of places. We can do that later. (Code coverage is added as a comment on every PR, so the development branch code coverage is shown here)

@jacalata
jacalata merged commit f142453 into main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants