Add funnel functionality to C library - #28
Open
mastermakrela wants to merge 2 commits into
Open
Conversation
skialpine
added a commit
to skialpine/libtailscale
that referenced
this pull request
Jul 12, 2026
…tputs Informed by tailscale#28 (mastermakrela/add-funnel): - Guard the empty-CertDomains case in the Funnel entrypoint so enabling Funnel before the node has a cert (not logged in / Funnel not approved) returns an error instead of panicking and taking down the Go runtime + host app. - tailscale_get_cert_domain now uses the direct tsnet.Server.CertDomains() accessor (confirmed present in tailscale v1.94.1) instead of a LocalClient status round-trip. - .gitignore the mac/ios/android build outputs (.dylib, xcframework, android/, include/, out/).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on Tailscale in js1 I've noticed that while
tailscale serverequivalent was present,tailscale funnelwas missing, although it's available in the underlying tsnet library.This PR exposes it to be usable from C.
Contributions:
tailscale_listen_funnel— starts a funnel instead of tailnet only listener, otherwise equivalent totailscale_listentailscale_cert_domains— retrieves the domain name under which the funnel is accessible. nice to have for better terminal messagetailscale_accept_nonblocking— not directly connected to the funnel, but helpful for not blocking the js event loop withtailscale_acceptAlso, as I was editing it anyway, I've also fixed some typos in
tailscale.h.I see there is a failing check, but I can't see the whole message. Please let me know what I have to correct and I'll gladly do it. :)
Footnotes
PR is a possible future work, but currently FFI in JS is not really standardized. So I've made a separate repo for now. ↩