Skip to content

Update README.md - #178

Merged
tcheeric merged 1 commit into
tcheeric:developfrom
x1watt:patch-1
Sep 27, 2024
Merged

tcheeric merged 1 commit into
tcheeric:developfrom
x1watt:patch-1

Conversation

@x1watt

@x1watt x1watt commented Aug 26, 2024

Copy link
Copy Markdown
Contributor

Adding detailed instructions for pom.xml

Adding detailed instructions for pom.xml
@x1watt

x1watt commented Aug 26, 2024

Copy link
Copy Markdown
Contributor Author

This patch is related to the conversation at #176

Comment thread README.md
```xml
<properties>
<nostr-java.version>0.6.1-SNAPSHOT</nostr-java.version>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property:
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
is already defined in nostr-java's pom.xml.

your project might have additional explicit dependency for it above and beyond what's required for nostr-java, but that is exclusive to your project and unnecessary here as part of general instruction.

Comment thread README.md
</properties>
```

Add Jitpack to the repositories:

@avlo avlo Aug 26, 2024 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obtaining nostr-java library jars. Two options:

Option 1: For pre-compiled binaries, add Jitpack to pom.xml repositories:

<repositories>
    <repository>
        <id>jitpack.io</id>
        <url>https://jitpack.io</url>
    </repository>
</repositories>

Option 2: To build and install your own nostr-java binaries:

$ cd <your_git_home_dir>
$ git clone git@github.com:tcheeric/nostr-java.git
$ cd nostr-java
$ git checkout <relevant_branch>
$ mvn clean install

@tcheeric

tcheeric commented Aug 27, 2024 via email

Copy link
Copy Markdown
Owner

@tcheeric
tcheeric changed the base branch from main to develop September 27, 2024 16:22
@tcheeric
tcheeric merged commit b893f42 into tcheeric:develop Sep 27, 2024
@x1watt

x1watt commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

This is still on the development branch, why not on the main one?

Right now it is kept invisible to new users since they just see the main branch by default with the old instructions.

@tcheeric

tcheeric commented Sep 27, 2024 via email

Copy link
Copy Markdown
Owner

@x1watt

x1watt commented Sep 27, 2024

Copy link
Copy Markdown
Contributor Author

Thank you, just puzzled why it didn't went directly. Please do continue the good work, this is without doubt the best java library for nostr.

@tcheeric

tcheeric commented Sep 27, 2024 via email

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants