Change socialLinks.other to array of {label, url} entries - #117
Merged
Conversation
Match the shape mobile is sending: each 'other' social link now has a required label (display name) and url. Replace the [String] sub-schema with a typed sub-schema (no _id on entries), update the request body types in updateUser and joinEventAsGuest, and adjust the guest-join contact-method guard to require a non-empty url on at least one entry. Also enable runValidators on the updateUser updateOne so the new sub-schema's required-field rules are enforced on partial updates, preventing silent acceptance of malformed entries. Refresh API_REFERENCE and DATABASE_SCHEMA to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A one-time data cleanup was run against the cluster: 2 leftover test users from the previous PR's verification had legacy string entries in `socialLinks.other`; their `socialLinks.other` was unset.