Skip to content

Resolve nullable warnings#44

Merged
teesofttech merged 1 commit into
masterfrom
chore/resolve-nullable-warnings
Jun 14, 2026
Merged

Resolve nullable warnings#44
teesofttech merged 1 commit into
masterfrom
chore/resolve-nullable-warnings

Conversation

@teesofttech

Copy link
Copy Markdown
Owner

Summary

  • Add explicit nullability/defaults to SDK request and response models
  • Align JSON mapping behavior with optional Tableau response fields
  • Enable TreatWarningsAsErrors for the core TableauSharp package
  • Add regression tests for missing optional project, user, and view fields

Closes #27

Verification

  • dotnet build TableauSharp.sln -c Release --no-restore
  • dotnet test TableauSharp.sln -c Release
  • dotnet pack src/TableauSharp/TableauSharp.csproj -c Release --no-build -p:ContinuousIntegrationBuild=true -p:PackageVersion=0.1.0-alpha.2 -o ./artifacts

Copilot AI review requested due to automatic review settings June 14, 2026 19:34
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@teesofttech, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 19 minutes and 16 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 84fbe7c2-330d-445d-b887-0ad76f40df12

📥 Commits

Reviewing files that changed from the base of the PR and between 20a91b2 and d34467d.

📒 Files selected for processing (29)
  • src/TableauSharp/Common/Models/ErrorResponse.cs
  • src/TableauSharp/Embedding/Models/TrustedTicketRequest.cs
  • src/TableauSharp/Embedding/Models/TrustedTicketResponse.cs
  • src/TableauSharp/Embedding/Services/EmbeddingService.cs
  • src/TableauSharp/Permissions/Models/PermissionCapabilityAssignment.cs
  • src/TableauSharp/Permissions/Models/PermissionSyncRequest.cs
  • src/TableauSharp/Permissions/Models/TableauPermission.cs
  • src/TableauSharp/Projects/Models/ProjectCreateRequest.cs
  • src/TableauSharp/Projects/Models/ProjectUpdateRequest.cs
  • src/TableauSharp/Projects/Models/TableauProject.cs
  • src/TableauSharp/Projects/Services/ProjectService.cs
  • src/TableauSharp/TableauSharp.csproj
  • src/TableauSharp/Users/Models/GroupCreateRequest.cs
  • src/TableauSharp/Users/Models/TableauGroup.cs
  • src/TableauSharp/Users/Models/TableauUser.cs
  • src/TableauSharp/Users/Models/UserCreateRequest.cs
  • src/TableauSharp/Users/Models/UserUpdateRequest.cs
  • src/TableauSharp/Users/Services/GroupService.cs
  • src/TableauSharp/Users/Services/UserService.cs
  • src/TableauSharp/Workbooks/Models/ExportRequest.cs
  • src/TableauSharp/Workbooks/Models/ExportResponse.cs
  • src/TableauSharp/Workbooks/Models/TableauView.cs
  • src/TableauSharp/Workbooks/Models/TableauWorkbook.cs
  • src/TableauSharp/Workbooks/Models/WorkbookPublishRequest.cs
  • src/TableauSharp/Workbooks/Services/ViewService.cs
  • src/TableauSharp/Workbooks/Services/WorkbookService.cs
  • test/TableauSharp.Tests/Projects/ProjectServiceTests.cs
  • test/TableauSharp.Tests/Users/UserServiceTests.cs
  • test/TableauSharp.Tests/Workbooks/ViewServiceTests.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/resolve-nullable-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@teesofttech
teesofttech merged commit 1d4d846 into master Jun 14, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Resolve nullable warnings and introduce warning policy

2 participants